Conversation
BTW, the reason for this is that memory64 is based on the wasm-3.0 branch of the spec repo where those proposals are already merged. |
Makes sense -- I think this is going to become more painful for WABT over time as more proposals go this direction (at least until WABT implements function-references+gc or is refactored on top of wasm-tools or binaryen). It's caused some issues in the https://github.com/WebAssembly/testsuite/ repo; e.g. memory64 doesn't change |
Ah yes, I guess we should modify update-testsuite.sh in the test suite repo so that it is aware that not all proposals forked from main. |
This means that the memory64 proposal now only contains that tests that differe from its upstream branch which is wasm-3.0, instead of including basically all test files. See WebAssembly/wabt#2495
|
Can we remove |
|
sure! |
This means that the memory64 proposal now only contains that tests that differe from its upstream branch which is wasm-3.0, instead of including basically all test files. See WebAssembly/wabt#2495
The memory64 `table.wast` test has started to depend on function-references and gc (which WABT doesn't support yet), so vendor an older version of the test.
d96bd73 to
fe6b537
Compare
Done. |
The memory64
table.wasttest has started to depend on function-references and gc (which WABT doesn't support yet), so vendor an older version of the test.